Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: catch error msgs in ns/tablet client #3587

Merged
merged 7 commits into from
Nov 16, 2023
Merged

feat: catch error msgs in ns/tablet client #3587

merged 7 commits into from
Nov 16, 2023

Conversation

vagetablechicken
Copy link
Collaborator

closes #3562

@github-actions github-actions bot added documentation Improvements or additions to documentation workflow CICD related storage-engine openmldb storage engine. nameserver & tablet labels Nov 10, 2023
@vagetablechicken vagetablechicken force-pushed the 3562-tablet-client-loadtable-should-show-error-msg branch from 129494e to 4ca8cfa Compare November 10, 2023 07:18
@github-actions github-actions bot removed the workflow CICD related label Nov 10, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (825d155) 75.33% compared to head (55796e2) 75.37%.

Files Patch % Lines
src/client/ns_client.cc 0.00% 34 Missing ⚠️
src/client/tablet_client.cc 78.78% 7 Missing ⚠️
src/sdk/sql_cluster_router.cc 66.66% 3 Missing ⚠️
src/datacollector/data_collector.cc 0.00% 2 Missing ⚠️
src/base/status.h 0.00% 1 Missing ⚠️
src/tablet/tablet_impl.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3587      +/-   ##
============================================
+ Coverage     75.33%   75.37%   +0.04%     
  Complexity      635      635              
============================================
  Files           727      727              
  Lines        130673   130659      -14     
  Branches       1317     1317              
============================================
+ Hits          98446    98490      +44     
+ Misses        31936    31878      -58     
  Partials        291      291

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 merged commit 84a1ffc into 4paradigm:main Nov 16, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqy222 lqy222 lqy222 approved these changes

@dl239 dl239 dl239 approved these changes

@tobegit3hub tobegit3hub Awaiting requested review from tobegit3hub

@aceforeverd aceforeverd Awaiting requested review from aceforeverd

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tablet client LoadTable should show error msg
3 participants
@vagetablechicken @dl239 @lqy222